dbt-core
dbt-core copied to clipboard
patch for bigquery unittest with sql_header
Resolves #9775 Based of @takemikami post on fixing SQL header integration in unit tests for BigQuery.
Problem
Solution
Checklist
- [x] I have read the contributing guide and understand what's expected of me.
- [x] I have run this code in development, and it appears to resolve the stated issue.
- [ ] This PR includes tests, or tests are not required or relevant for this PR.
- [ ] This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
- [x] This PR includes type annotations for new and modified functions.
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.
In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.
CLA has not been signed by users: @takemikami
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 88.82%. Comparing base (300aa09) to head (478cd62).
:warning: Report is 133 commits behind head on main.
:x: Your patch status has failed because the patch coverage (20.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
Additional details and impacted files
@@ Coverage Diff @@
## main #11386 +/- ##
==========================================
- Coverage 88.90% 88.82% -0.08%
==========================================
Files 191 191
Lines 24391 24394 +3
==========================================
- Hits 21684 21669 -15
- Misses 2707 2725 +18
| Flag | Coverage Δ | |
|---|---|---|
| integration | 85.77% <100.00%> (-0.15%) |
:arrow_down: |
| unit | 62.81% <20.00%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Components | Coverage Δ | |
|---|---|---|
| Unit Tests | 62.81% <20.00%> (-0.01%) |
:arrow_down: |
| Integration Tests | 85.77% <100.00%> (-0.15%) |
:arrow_down: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
supplanted by #11614