dbt-core icon indicating copy to clipboard operation
dbt-core copied to clipboard

Event time ref filtering

Open MichelleArk opened this issue 1 year ago • 3 comments

Resolves #

Problem

Solution

Checklist

  • [ ] I have read the contributing guide and understand what's expected of me.
  • [ ] I have run this code in development, and it appears to resolve the stated issue.
  • [ ] This PR includes tests, or tests are not required or relevant for this PR.
  • [ ] This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • [ ] This PR includes type annotations for new and modified functions.

MichelleArk avatar Aug 22 '24 20:08 MichelleArk

Codecov Report

Attention: Patch coverage is 96.72131% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.89%. Comparing base (ab500a9) to head (f53204f). Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10594      +/-   ##
==========================================
- Coverage   88.90%   88.89%   -0.02%     
==========================================
  Files         180      180              
  Lines       22785    22842      +57     
==========================================
+ Hits        20257    20305      +48     
- Misses       2528     2537       +9     
Flag Coverage Δ
integration 86.09% <83.60%> (-0.04%) :arrow_down:
unit 62.44% <91.80%> (+0.07%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.44% <91.80%> (+0.07%) :arrow_up:
Integration Tests 86.09% <83.60%> (-0.04%) :arrow_down:

codecov[bot] avatar Aug 22 '24 20:08 codecov[bot]

This PR is currently waiting for a change in dbt-adapters and dbt-postgres. Once that change is available, we'll be making another update to this PR and then opening it for review 🙂

QMalcolm avatar Sep 11 '24 17:09 QMalcolm

However, we've had external eyes on it. It's well gated, well tested, and confirmed backwards compatible. LGTM 🚀

echoing this as well ✅

MichelleArk avatar Sep 12 '24 22:09 MichelleArk

codecov check summaries are stale, here's what you actually see clicking into 'details': Screenshot 2024-09-12 at 6 15 03 PM

MichelleArk avatar Sep 12 '24 22:09 MichelleArk