dbt-bigquery icon indicating copy to clipboard operation
dbt-bigquery copied to clipboard

Docker image for 1.7.7 became much bigger that 1.7.6

Open xemuliam opened this issue 10 months ago • 4 comments

Is this a new bug in dbt-bigquery?

  • [X] I believe this is a new bug in dbt-bigquery
  • [X] I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

Looks like smth. goes wrong with version 1.7.7 Changelog is tiny enough but actual size of docker image became unexpectedly big image

Expected Behavior

I do expect to not see so much growth for image size. There must be very cardinal and significant changes inside to become 42% bigger than previous version

Steps To Reproduce

pull the 1.7.2, 1.7.4, 1.7.6 and1.7.7 versions from registry and compare sizes

Relevant log output

No response

Environment

No response

Additional Context

No response

xemuliam avatar Mar 29 '24 14:03 xemuliam

@xemuliam https://github.com/dbt-labs/dbt-bigquery/pull/1154's addition of the [pandas] option might make the difference? You're right that I don't see much else going on.

I'll flag this internally though, but I'm not sure this qualifies as "bug".

dataders avatar Apr 01 '24 19:04 dataders

I understand this issue doesn't look like a bug. However there were very few options to choose issue type

xemuliam avatar Apr 01 '24 19:04 xemuliam

@xemuliam #1154 addition of the [pandas] option might make the difference? You're right that I don't see much else going on.

I'll flag this internally though, but I'm not sure this qualifies as "bug".

Agreed, it's very likely [pandas]. And now that google-cloud-bigquery yanked 3.20, we can look to see if we can remove that requirement again for the next patch.

And agreed it's not quite a bug, but it's certainly an unexpected change.

mikealfare avatar Apr 02 '24 00:04 mikealfare

Here is the related information: https://github.com/googleapis/python-bigquery/pull/1880

xemuliam avatar Apr 15 '24 07:04 xemuliam