dbt-bigquery icon indicating copy to clipboard operation
dbt-bigquery copied to clipboard

feat: convert vals to strings

Open jimmyshah opened this issue 2 years ago • 3 comments

resolves #1001

Problem

There is a bug currently that requires runtime_config properties values to be strings. As a result, integer values need quotes around them in the yml files, which is awkward.

With this PR, values are cast as strings, so that the properties can be set in a more expected way.

ADAP-1007

Solution

In _configure_batch(), I added a check for runtime_config.properties. If they exist, I iterate through the dictionary to cast the values as strings. Changing this part of the code was suggested as an option in #1001.

Checklist

  • [x] I have read the contributing guide and understand what's expected of me
  • [x] I have run this code in development and it appears to resolve the stated issue
  • [x] This PR includes tests, or tests are not required/relevant for this PR
  • [x] This PR has no interface changes

jimmyshah avatar Nov 14 '23 00:11 jimmyshah

@dbeatty10 @McKnight-42 Anything I can do to help move this PR forward?

jimmyshah avatar Nov 15 '23 22:11 jimmyshah

@jimmyshah this is queued up for a member of our engineering team to give it an initial review and provide any relevant feedback. We don't have a set timeline for when they will be able to get to it though.

dbeatty10 avatar Nov 16 '23 07:11 dbeatty10

@dbeatty10 Got it! I didn't know there was a review queue, so that's helpful context. Thank you for the update!

jimmyshah avatar Nov 16 '23 22:11 jimmyshah

This PR has been marked as Stale because it has been open with no activity as of late. If you would like the PR to remain open, please comment on the PR or else it will be closed in 7 days.

github-actions[bot] avatar Oct 02 '24 02:10 github-actions[bot]

Although we are closing this PR as stale, it can still be reopened to continue development. Just add a comment to notify the maintainers.

github-actions[bot] avatar Oct 10 '24 02:10 github-actions[bot]