corp
corp copied to clipboard
dbt-labs
Update: Proserv Style Guide Updates
@graciegoheen A change to the original style guide would update anyone who hasn't created their own style guide - for this reason we should be helping others create a copy of the style guide (Just as we do with the PR template / READMEs) and relink to their own file in their repo.
Anyone who is linking straight to dbt Labs' style guide would want to relink to an older version if they feel they need to. The second way we could do this is just save this in one of our own repositories for Pro Serv?
Approving it so we can get this thing out into the world!
Though, still pointing out that how we name yml files is contrary to how it is laid out in the guide: https://docs.getdbt.com/guides/best-practices/how-we-structure/1-guide-overview
If we want to just get it out I’d rather have it reflect what we put out there and then talk about whther we want the work to change the article + this - better to be consistent imo!
@SamHarting I fixed this example by just removing the reference to int_payments.sql, since that was covered by int_customers__unioned.sql which is already following the naming convention! Ready for review.
@b-per I think that the change requested has to be reviewed + approved by you to get the "1 change requested" cleared!
Left two suggestions but feel free to take them or leave them. Looks great!
@carolynghosh - Committed both!