cdk-sops-secrets icon indicating copy to clipboard operation
cdk-sops-secrets copied to clipboard

feat: splitup the policy creation if too many parameters are created …

Open lenderom opened this issue 1 year ago • 3 comments

When creating a large set of parameters the maxium policy size of is exceeded:

image

This PR improves the parameter policy creation by splitting up the policy, if it would exceed the maximum policy size.

Additionally the property keySeperator was renamed to keySeparator to match flattenSeparator.

lenderom avatar Aug 23 '24 11:08 lenderom

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.70%. Comparing base (8caaadb) to head (082e6d7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1050   +/-   ##
=======================================
  Coverage   75.70%   75.70%           
=======================================
  Files           3        3           
  Lines         354      354           
=======================================
  Hits          268      268           
  Misses         49       49           
  Partials       37       37           
Flag Coverage Δ
go-lambda 75.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 23 '24 12:08 codecov[bot]

I would like to test a prebuild version now, to check if it work's like expected.

lenderom avatar Aug 23 '24 13:08 lenderom

I tested it, resulting in a different error. The policy split up worked, but now the respone object of the custom resource is too large:

image

lenderom avatar Aug 23 '24 13:08 lenderom

I sucessfully deploy this fixed version with 120 parameters. The policy was split up in 2,5 managed policys.

lenderom avatar Oct 07 '24 11:10 lenderom