embedded-hal-mock icon indicating copy to clipboard operation
embedded-hal-mock copied to clipboard

Published 20 hours ago • verified publisher icon dbrgn

Add support for ToggleableOutputPin for pin::Mock

Open cdunster opened this issue 2 years ago • 3 comments

This PR adds support for the ToggleableOutputPin trait from the embedded-hal crate.

Possibly closes #30, although that issue mentions wanting to do this in a stateful way but currently, the mocks don't seem to work that way. Instead, they just work on the transactions and have no internal pin state.

cdunster avatar Sep 14 '23 15:09 cdunster

@cdunster hi, there are new conflicts introduced by other merges. Would you mind updating your branch? Thanks.

dbrgn avatar Nov 23 '23 22:11 dbrgn

Hi @dbrgn, done. Thanks for looking into this PR.

cdunster avatar Nov 26 '23 09:11 cdunster

Hi @dbrgn and happy new year, I've updated this PR to work with the new StatefulOutputPin that replaces ToggleableOutputPin in embedded-hal v1. The CI is passing so it would be nice to get this merged, let me know if I can help. Thanks.

cdunster avatar Jan 11 '24 10:01 cdunster

Thanks for the updates! I'll rebase this branch against main. The pin module was renamed to digital in #113, so I'll have to adjust the second commit for that.

Edit: A regular rebase didn't properly detect the rename, but adding the --strategy-option="find-renames=10" argument helped 🙂

dbrgn avatar May 30 '24 20:05 dbrgn