embedded-hal-mock icon indicating copy to clipboard operation
embedded-hal-mock copied to clipboard

Published 20 hours ago • verified publisher icon dbrgn

IO implementation for embedded-io

Open Artur-Romaniuk opened this issue 1 year ago • 7 comments

Related to #100

Artur-Romaniuk avatar Dec 23 '23 20:12 Artur-Romaniuk

Rebased on main. Would love to have some feedback.

Artur-Romaniuk avatar Jan 14 '24 09:01 Artur-Romaniuk

This PR went stale for a while now. @dbrgn could take a look?

Artur-Romaniuk avatar Feb 03 '24 11:02 Artur-Romaniuk

@Artur-Romaniuk because this PR was created on top of the delay branch (#104), I wanted to wait until that branch is ready and merged (and left feedback there) to make review easier.

If you want to make PRs easier to review, try to keep them small and focussed. Having a lot of practice with git rebase (especially interactive rebase) helps a lot with that.

dbrgn avatar Feb 03 '24 20:02 dbrgn

@Artur-Romaniuk because this PR was created on top of the delay branch (#104), I wanted to wait until that branch is ready and merged (and left feedback there) to make review easier.

If you want to make PRs easier to review, try to keep them small and focussed. Having a lot of practice with git rebase (especially interactive rebase) helps a lot with that.

That was a fuckup... Must have rebased this branch on wrong origin/main. Force pushed rebased version with all unecessary commits dropped.

Artur-Romaniuk avatar Feb 04 '24 18:02 Artur-Romaniuk

Any chance this gets fixed and merged in a near future?

victorbnl avatar Jul 24 '24 12:07 victorbnl

@Artur-Romaniuk do you have plans to finish this PR, or would you like for someone else to take over?

dbrgn avatar Sep 13 '24 20:09 dbrgn