Danilo Bargen

Results 535 comments of Danilo Bargen

Good point. I assume with "its own state" you mean some fields in the `Common` struct. If I'm not mistaken, if the task has not yet kicked in, we only...

Regarding 3, the spec says: > A receiving client MUST notify the user application about the incoming 'disconnected' message, along with the id field. If the client should react to...

Regarding 6: > Proposal: Return a protocol error instead. I agree. Not sure why I made that mistake.

Regarding 7: > Proposal: Crash instead of handling the message. I agree.

Regarding 8: > The task_supported_types seems unnecessary to me. I believe this was an optimization to avoid having to lock the `Arc` around the task just for checking whether the...

https://llogiq.github.io/2018/09/13/smallvec.html

> make sure that we don't consume too much RAM when importing the data (currently, they are first fully loaded into memory and only then stored in the database -...

@johan12345 Hmm, that's interesting! I assume this information is extracted by using the geographical relation (it's "inside" a certain administrative boundary). However, that does indeed sound expensive to calculate for...

Regarding contributions: I did mean to take a look, but my calendar is totally stuffed until at least mid-October... So don't count on me, sorry. (I'm happy to test and...

What about not using a classical installer, but building an MSIX instead? https://learn.microsoft.com/en-us/windows/msix/overview We do that for Threema Desktop, it's quite painless and Windows ships all necessary tools. Only caveat:...