Danilo Bargen
Danilo Bargen
By the way, why not just `--config ` for this PR?
See #162! If you agree with that, the config directory should be returned together with `PageSource::ConfigVar` if it was overridden in the config.
> I had it so that if the given path was a directory, the config directory would be overridden and otherwise it would be just the config file location. I...
@niklasmohrin sorry for missing #266, I wanted to get PRs unblocked starting at the oldest, and didn't yet see that you already submitted a proposed solution (I skimmed over it...
@niklasmohrin everything should be updated and all your feedback should be addressed!
> Nice! Some more comments, a handful of them are suggestions about removing code comments - I think that the code following those comments is just as expressive (if not...
Great, thanks for the review. All issues should have been addressed. Regarding the comments: Yes, absolutely, often the clarity of the code can be improved with refactoring or better naming....
🎉 Thanks! All feedback should now be addressed.
> In #274, I noted that there is the possibility of using `cross` which cross-compiles using docker containers. Does that just build for ARM, or actually on an Android device?
Android is not currently supported. Just out of curiosity, what kind of Android device do you have that would benefit from a tldr installation?