Dmitry Brant comments

Results 23 comments of


                                            Dmitry Brant

String resources for Temporary Accounts feature.

@sharvaniharan It's ok to let these sit for a bit before merging. I'll confirm next week.

String resources for Temporary Accounts feature.

@cooltey This can now be merged, so that these strings can be digested by TWN.

Experimental: in-app updates

Very nice! Some initial comments: - Obviously this won't do anything in builds released to other stores, e.g. Samsung, Huawei, etc. But we should make sure in those cases it...

Support exporting history to csv

Cleaning up old PRs. For the moment we do not plan on including this functionality in our releases. Please feel free to use this in your own fork(s).

Use Jsoup's stream implementation

Could you be more specific about why this is an improvement?

Use Jsoup's stream implementation

A bit of profiling shows no difference in performance.

Integrate In-App Internet censorship circumvention

Thanks! I'm not sure we're ready at a product level to have this feature be part of the app. I would suggest continuing the conversation in the Phabricator task until...

Integrate In-App Internet censorship circumvention

Cleaning up some older pull requests; Certainly not to suggest this wouldn't be useful, but just to keep the conversation in one place (the Phabricator task).

Improve code using serializable extensions

This PR can be merged only if it is slimmed down to _only_ add the serializable extensions, and nothing else. (No moving of constants, no changes to how we pass...

@Williamrai It's an interesting idea, but can you be more specific about what boilerplate this reduces? Most of our usages of `MaterialAlertDialogBuilder` are pretty concise already. Maybe it would help...