react-animate-on-scroll icon indicating copy to clipboard operation
react-animate-on-scroll copied to clipboard

Typescript Type Definitions Outdated

Open brybrophy opened this issue 6 years ago • 3 comments

When using typescript, the following properties cause errors because they are not included in the type definitions:

  • afterAnimatedIn
  • afterAnimatedOut
  • animatePreScroll

brybrophy avatar Jun 27 '18 20:06 brybrophy

I've not used r-a-o-s with typescript before. In fact, i've not used typescript much either. Do you mean that I just need to add definitions in the propTypes section for those props to resolve this?

dbramwell avatar Jun 28 '18 12:06 dbramwell

as stated the types are still on version 2.1.2 https://www.npmjs.com/package/@types/react-animate-on-scroll

@dbramwell yes the propTypes needs to be updated someone can update the type definitions accordingly: https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react-animate-on-scroll/index.d.ts

paul-vd avatar Jan 29 '20 21:01 paul-vd

I have forked the types and i'm just waiting for your propTypes so that i can update the @types

paul-vd avatar Jan 29 '20 21:01 paul-vd