Davíd Brakenhoff

Results 91 comments of Davíd Brakenhoff
trafficstars

Option for passing engine has been implemented by #13. Issue remains open to figure out why engine="numba" fails and engine="numpy" produces a communality >100% and some runtime warnings about illegal...

Sounds like a good idea :)! I had to modify your code a bit to get the same result between both optimization methods, but after that change they produce nearly...

Checking for zero length stress_period_data makes sense to me. The least we should do is log a warning, but I think it also makes sense to prevent the package from...

If the method has "set_" in the name, I think this is ok, as the function name is pretty clear that it's setting something? But good to review whether this...

Partially solved by #242 where the cells with sea are derived from the DTM. Keeping this issue open to add function to obtain the shapefile @OnnoEbbens proposed. Once this is...

@KeesdeVriesW any chance you have a good shapefile that you'd be willing to commit?

Naming: - all functions that download source data should start with `download_*` - think about name for regridding data array to model coordinates and adding to dataset

Move surface_water download methods to `nlmod/read/`

Some really nice work in in #449, but one thing that I think we should still look at is to make it more explicit which function(s) download data, and which...