Dave Bort

Results 68 comments of Dave Bort

Link to landed trunk PR: * https://github.com/pytorch/executorch/pull/4633 Link to release branch PR: * https://github.com/pytorch/executorch/pull/4638 Criteria category and reasons: * Fix docs

All of the packages involved here have had a few releases since this issue was originally reported. I'm going to close this in the hopes that it's working with executorch...

Also for what it's worth, I'm trying to merge https://github.com/dvidelabs/flatcc/pull/306 into upstream flatcc to let us remove `-DEXECUTORCH_SEPARATE_FLATCC_HOST_PROJECT` and similar hacks

> I'm not sure about the workaround to use release mode. The command used in the ci script is already using --release. Ok, thanks for looking into that. > As...

Though theoretically executor_runner shouldn't even need to know about libflatccrt: it should inherit the dep from the PUBLIC section of https://github.com/pytorch/executorch/blob/538bfaf3d5a25baf2d094c178b0fe9e708ed16f2/devtools/CMakeLists.txt#L179-L183 But in this case, you could try updating this...