solr-ocrhighlighting icon indicating copy to clipboard operation
solr-ocrhighlighting copied to clipboard

Feat/update example books

Open M3ssman opened this issue 1 year ago • 2 comments
trafficstars

Contains some modifications to the example section, altogether with some minor updates.

Targets some current difficulties in the actual implementation:

  • docker-compose turned into docker compose
  • needed to reduce process pool size, actual setup always freezes machine
  • if only one single book missing process starts from scratch again, hence individual checks

If you find it useful, feel to merge :slightly_smiling_face:

M3ssman avatar Apr 25 '24 09:04 M3ssman

First of all, thanks for incorporating the feedback :-) However, that's a pretty large diff, that touches almost every part of the script, for a rather small set of changes. Can you:

  • keep the existing style and general structure of the script
  • keep the changes you need localized to only the places that need them?

And I'd only use the logging API for debugging stuff, the stdout output was intentionally kept rather brief and readable. Spamming a log line for every iteration is kind of excessive.

jbaiter avatar Apr 26 '24 12:04 jbaiter

Sorry, I didn't realize your latest remarks at first sight! But anyway, it's all only a proposal. If you can't go with, it's okay and just leave it out.

M3ssman avatar Apr 26 '24 13:04 M3ssman