mirador-textoverlay icon indicating copy to clipboard operation
mirador-textoverlay copied to clipboard

Bug with manifest on onFragment

Open PonteIneptique opened this issue 2 years ago • 5 comments

Hi there :)

I have been playing with the plugin in the last day, and something failed, probably because of a bad ALTO but I have stopped javascript for too long to be able to pinpoint more than a specific issue, which is https://github.com/IIIF-Commons/manifesto/issues/121

Basically, there seems to be an issue with Fragment, which could be caused downstream of this plugin or downstream of manifesto. I wanted you to know this :)

PonteIneptique avatar Feb 01 '23 06:02 PonteIneptique

Hey :) manifesto.js was updated (4.2.17), unfortunately I am unable to use it as a fix while using your repo in NPM. Could you upgrade the dep / build ? :)

PonteIneptique avatar Feb 01 '23 15:02 PonteIneptique

I just published 0.3.8 on npm, can you check if it fixes your problem?

jbaiter avatar Feb 24 '23 17:02 jbaiter

Hey @jbaiter :) Yes it fixed the plugin issue but the code seems to be the same in the original mirador.js code (see the dirty fix I have to deploy: https://github.com/PonteIneptique/htr-light-viz-action/blob/main/dirty-fix.py )

This might be due to a parsing issue, or an ALTO having an incorrect line ?

PonteIneptique avatar Feb 27 '23 07:02 PonteIneptique

Can you give me a sample ALTO that fails due to this bug?

jbaiter avatar Mar 02 '23 17:03 jbaiter

I am gonna try to set up an example by next week, I am in slow mode since a couple of days and I am trying to get back in the game ^^

PonteIneptique avatar Mar 03 '23 07:03 PonteIneptique