strava-ruby-client icon indicating copy to clipboard operation
strava-ruby-client copied to clipboard

Published 20 hours ago • verified publisher icon dblock

Rate limiting

Open adamwolf opened this issue 2 years ago • 3 comments

I'm trying to help with getting @simonneutert's rate limiting work for #11 over the finish line.

I'm handy with git, so feel free to ask me to rebase/squash/do whatever!

I'm not sure about all the choices I made handling the feedback from #50, especially the ResponseWrap/RaiseError thing.

Related:

  • #50

adamwolf avatar Jun 22 '22 15:06 adamwolf

@adamwolf Rebase this change so that it doesn't have any conflicts and get it to green, I'll take a look at the PR once it's there! Feel free to squash all the changes, but you don't have to.

dblock avatar Jun 22 '22 19:06 dblock

I rebased and the tests are green locally. Github says it needs maintainer approval to run workflows since I'm a first-time contributor here.

adamwolf avatar Jun 22 '22 20:06 adamwolf

1 Warning
:warning: [DEPRECATION] check is deprecated. Please use check! instead.

Generated by :no_entry_sign: Danger

dangerpr-bot avatar Jun 23 '22 22:06 dangerpr-bot

Thanks @simonneutert for finishing this up! See https://github.com/dblock/strava-ruby-client/pull/50.

dblock avatar Dec 29 '22 03:12 dblock