dblock
Group virtual and non-virtual activities when calculating leaderboards
It looks like Virtual Ride and Ride activities are separated when shown on the leaderboard. I assume the same thing would happen for Virtual Run and Run and all other virtual/non-virtual activities.
> Leaderboard elapsed time since past 14 days
...
4: richard :cyclist: 3h47m52s
...
6: richard :cyclist: 2h48m28s
...
These are impossible to tell apart at the moment.
Seems like there are 2 options to fix this:
- Group virtual and non-virtual activities when calculating leaderboards (and the medal icons)
- Add a marker to differentiate between virtual/non-virtual activities (eg:
:cyclist: (virtual))
I think option 1 probably results in a nicer leaderboard summary
I think they use the same Emoji in https://github.com/dblock/slack-strava/blob/3b7abc9de627f96342ba89d817a6cdf59089eb3a/slack-strava/models/activity_methods.rb#L230, so the easiest fix is likely to just change that. Want to contribute and help make this simple fix first?
I really like the idea of grouping, too. It might require a bit more surgery. We should consider whether adding an option to group vs. not group is a good idea vs. just group all the time.
