slack-strava icon indicating copy to clipboard operation
slack-strava copied to clipboard
verified publisher icon dblock

BugFix - Medals should be assigned based on Rank & Activity Type

Open JonEHolland opened this issue 8 months ago • 1 comments

Second attempt at fixing this, this time leaving the aggregation alone, so the existing leaderboard logic remains as-is.

In this case, I'm introducing application level filtering to ensure only activities of the same type are considered when picking the medal emoji.

Apologies, I don't have a ruby env setup on this laptop and vibe coded this with cursor.

JonEHolland avatar May 01 '25 23:05 JonEHolland

Apologies, I don't have a ruby env setup on this laptop and vibe coded this with cursor.

I mean that's pretty awesome, but maybe you should get yourself setup on Ruby (easy) because you love contributing to this project? ;)

dblock avatar May 03 '25 12:05 dblock

Got some time for this today and sunk the aggregation into aggregate!. Thanks for your help @JonEHolland!

dblock avatar May 25 '25 12:05 dblock

Ported to https://github.com/dblock/discord-strava/commit/0960bfe6f054c400cae136e754bb4837eae99363 as well.

dblock avatar May 25 '25 14:05 dblock