open-weather-ruby-client icon indicating copy to clipboard operation
open-weather-ruby-client copied to clipboard

Exposed the national weather alerts response in the One Call API

Open troya2 opened this issue 3 years ago • 1 comments

Added the feature, updated the relevant fixture, and added supporting specs.

troya2 avatar Mar 26 '21 23:03 troya2

1 Error
:no_entry_sign: One of the lines below found in CHANGELOG.md doesn't match the expected format. Please make it look like the other lines, pay attention to version numbers, periods, spaces and date formats.

* Exposed the national weather alerts response in the One Call API [@troya2](https://github.com/troya2)

Generated by :no_entry_sign: Danger

dangerpr-bot avatar Mar 26 '21 23:03 dangerpr-bot

Any interest in finishing this @troya2?

dblock avatar Dec 28 '23 14:12 dblock

@dblock Thanks for the prod - looking at it now. I haven't used VCR, so I'll have to work on that. The other items are easy. Committing them now.

troya2 avatar Dec 31 '23 22:12 troya2

@dblock I believe I've resolved all of your comments. Let me know if not. Happy new year!

troya2 avatar Dec 31 '23 23:12 troya2

Thanks for finishing this up! Want to help with co-maintenance of this gem? Make the next release? Drop me a note to dblock at dblock dot org with your rubygems username if yes.

dblock avatar Jan 02 '24 16:01 dblock