Daniel (dB.) Doubrovkine
Daniel (dB.) Doubrovkine
Thanks @nokados. My biggest concern is backwards compatibility, we cannot change the way existing parameters and their values work in the current interface without a major version bump, and a...
Seems reasonable. Note that the raw API calls to OpenSearch should be generated from spec in here, and not hand-written.
@nathaliellenaa The ML plugin APIs are in https://github.com/opensearch-project/opensearch-api-specification/blob/main/spec/namespaces/ml.yaml with tests in https://github.com/opensearch-project/opensearch-api-specification/tree/main/tests/plugins/ml. According to https://github.com/opensearch-project/opensearch-api-specification/issues/168 some are missing, which is where I'd start. - [x] DELETE /_plugins/_ml/agents/{} - [ ]...
[[Catch All Triage](https://github.com/opensearch-project/.github/blob/main/TRIAGING.md) - [1](https://github.com/dblock), [2](https://github.com/andrross/), [3](https://github.com/reta), [4](https://github.com/gaiksaya), [5](https://github.com/krisfreedain), [6](https://github.com/acarbonetto)]
Thanks. 1. Sign DCO, `git commit --amend -s`. 2. Make sure CI passes (`nox -rs format` to fix linter). 3. Add a test. Let's make sure this code actually works.
Good eyes. Please PR an update!
Is this fixed with the related OpenSearch issue @LantaoJin? [Catch All Triage - Attendees [1](https://github.com/dblock/), [2](https://github.com/krisfreedain), [3](https://github.com/andrross), [4](https://github.com/gkamat), [5](https://github.com/getsaurabh02)]
[[Catch All Triage](https://github.com/opensearch-project/.github/blob/main/TRIAGING.md) - [1](https://github.com/dblock), [2](https://github.com/reta)]
[[Catch All Triage](https://github.com/opensearch-project/.github/blob/main/TRIAGING.md) - [1](https://github.com/dblock), [2](https://github.com/andrross/), [3](https://github.com/reta), [4](https://github.com/gaiksaya), [5](https://github.com/krisfreedain), [6](https://github.com/acarbonetto)]
@skalibog if you want to contribute a fix and a test I'd gladly help merge! Someone will need to bring back CI first since Travis-CI is RIP, I would copy...