Daniel (dB.) Doubrovkine

Results 3332 comments of Daniel (dB.) Doubrovkine

With https://github.com/dblock/slack-strava/commit/dfff3c48252e241c487cab702ff9b608398e8999 one can `set threads none|daily|weekly|monthly` and activities will thread up.

[Catch All Triage - Attendees [1](https://github.com/dblock/), [2](https://github.com/krisfreedain), [3](https://github.com/andrross), [4](https://github.com/gkamat), [5](https://github.com/getsaurabh02)]

Catch All Triage - [1](https://github.com/dblock), [2](https://github.com/krisfreedain), [3](https://github.com/andrross), closing already released.

Big breaking change :( If `data, response, err` was flipped as `data, err, response`, would it be easier to migrate to? Does go allow to specify the first 2 objects...

I think we still want this. I'd want other maintainers to chime into this like @Jakob3xD.

Understandable. All this boilerplate should be generated though, the big ticket that someone should tackle first is #284 and this change becomes trivial.

Is this code generated from spec (it should be)? I am afraid the bug is in the generator or the spec. https://github.com/opensearch-project/opensearch-api-specification If not, ensuring these descriptions are correct and...

@m3et First, I merged this PR, thank you. I found other instances of the same in another client, https://github.com/search?q=org%3Aopensearch-project%20onlymissing&type=code, if you are interested in fixing those. > Can you elaborate...

This was a bug in the generator, the next run undid all these changes. I fixed it in https://github.com/opensearch-project/opensearch-py/pull/793/files#diff-999765094c323a96b13cc24c24aa13948be15e6beacda7747e83c300420f8018R626.