Daniel (dB.) Doubrovkine
Daniel (dB.) Doubrovkine
I'm hoping this gets (eventually) covered by the code generator, cc: @Xtansia.
We are working on adding plugins via a new code generator (first parts in https://github.com/opensearch-project/opensearch-java/pull/1052) from spec (https://github.com/opensearch-project/opensearch-api-specification). If you would like to help, a good place to start is...
Btw, you can use the generic client interface that should work for SQL, https://github.com/opensearch-project/opensearch-java/blob/main/guides/generic.md.
I am not sure. Generally `.generic()` and non-generic don't mix, but maybe @reta or @Xtansia know how?
Thanks, can you please explain why?
Thanks. FYI we're also working on generating this code from spec in #366, appreciate if you could contribute the missing setting(s) to https://github.com/opensearch-project/opensearch-api-specification.
@ste93cry want to give a PR a shot so we can look at it? Generally I like explicit returns personally too, but I am concerned about backwards compatibility as well.
I'll try to help here to break a tie ;) @Jakob3xD, absent of any existing code, if we were writing this library from scratch, do you agree that it's better...
> A bit off-topic, but if we want to talk about another major breaking change that would level up the SDK, we should consider providing users with typed request objects...
[Catch All Triage - [1](https://github.com/dblock), [2](https://github.com/reta), [3](https://github.com/amistrn), [4](https://github.com/krisfreedain)] cc: @ylwu-amzn @varun-lodaya this looks like a problem we should fix soon