Daniel (dB.) Doubrovkine

Results 3341 comments of Daniel (dB.) Doubrovkine

@jazzl0ver The Slack channel doesn't keep data for more than 30 days or so, care to port the description of the issue in detail here, please? [Catch All [Triage](https://github.com/opensearch-project/.github/blob/main/TRIAGING.md) -...

[Catch All Triage - [1](https://github.com/andrross), [2](https://github.com/dblock), [3](https://github.com/AmiStrn), [4](https://github.com/reta), [5](https://github.com/finnegancarroll)]

Looks like a bug. Want to try to write a (failing) spec for it and maybe a fix?

> if mongoid thinks it’s a change it should be tracked I completely agree with you. For backwards compatibility I would introduce an option (`track_nil: true/false`?). If you have time,...

@johnnyshields Possibly. As long as no existing specs fail and we document it thoroughly.

I say let's see a PR from @BrianLMatthews and we can discuss whether to merge/not merge it?

Naming-wise I think `track_blank` is simpler and clearer I think. Semantically this is incorrect, but I can't come up with a better option. "Track blank" means "track blank change history",...

I'm good with what @johnnyshields is suggesting, possibly as a start ;)

https://github.com/mongoid/mongoid-history/pull/257

Yes, please, definitely in favor! Much of this code is generated so that's where I'd make most changes.