Daniel (dB.) Doubrovkine

icon indicating a website link https://code.dblock.org icon indicating an email [email protected]

icon company @opensearch-project icon location New York, NY icon location @opensearch-project, ex-@aws, former CTO @artsy @ArtsyOpenSource, @vestris, active maintainer of @ruby-grape, hashie, @slack-ruby, @playplayio and more.

Results 2213 comments of Daniel (dB.) Doubrovkine

one should be able to change env variables when exposing a collection (nesting) with :using option

We're waiting for your PR @mcmegavolt !

Ruby 3: Entities exposing fields via Symbol#to_proc are broken

@rgalanakis Care to PR a fix?

to_xml doesn't work out of the box

If you add that in your app, I assume you get that behavior and everything works with Grape's `format :xml`?

to_xml doesn't work out of the box

@agileanimal should make that call - at the least he/we might want to document this

to_xml doesn't work out of the box

@mbleigh Right on.

to_xml doesn't work out of the box

@SegFaultAX I feel that your proposal does the same job as Grape formatters, in possibly a more elegant way. I would be open to allow blocks for formatters in Grape...

to_xml doesn't work out of the box

So we had an interesting chat here with some action items. Where're my pull requests? What I am paying you guys for? j/k :)

present_collection issue

You have a class `Users` that exposes `items` as itself it seems, that is indeed why. You need a `User` class to expose each entity.

present_collection issue

First, I think you're right there's a bug in the documentation, but I didn't try. In your code you cannot expose `:events` as `API::Entities::Events` because that's the same class :)...

raising ArgumentError if exposure_options[:using] does not respond to represent

I like it. Can you please fix the build (RuboCop) and update CHANGELOG?