Daniel (dB.) Doubrovkine comments

Results 3330 comments of


                                            Daniel (dB.) Doubrovkine

Ability to "flatten" nested entities into parent (e.g. for CSV)

I'll leave this open for a bit. FWIW, this morning my inclination is to merge this.

Ability to "flatten" nested entities into parent (e.g. for CSV)

I am still sitting on this, I'll take a close look. Would appreciate other people's opinion. Generally, I think I want to weed the "flatten" part out of this, the...

Ability to "flatten" nested entities into parent (e.g. for CSV)

@brianphillips Want to try and extract a `merge_with` PR out of this ?

#as_json confusion in Rails

I would be down with making sure all keys are symbols here, but I am not sure that patching `Hash` is the right way to go. I would write a...

Exposing a List of Entities

Define _doesn't get presented correctly_? The structure returned from a `group_by` is a hash, so you should use a new presenter for it that knows how to deal with it?

Wrong except option for nested entities

Indeed, it just wasn't implemented for nested except's, please contribute.

expose and method_missing

What's a scenario where this is a problem? I believe the right way to implement this is to respond accordingly to `:respond_to?`.

expose and method_missing

Ok, I don't disagree. Can you demonstrate the problem that you're trying to fix though in a test?

Format is "reserved"

This is the problem with defined functions vs. fields. It should be fixable, I would start by writing a spec.

Class reopening and inheritance.

I would expect this to succeed, so I say it's a bug.