Daniel (dB.) Doubrovkine

icon indicating a website link https://code.dblock.org icon indicating an email [email protected]

icon company @opensearch-project icon location New York, NY icon location @opensearch-project, ex-@aws, former CTO @artsy @ArtsyOpenSource, @vestris, active maintainer of @ruby-grape, hashie, @slack-ruby, @playplayio and more.

Results 2213 comments of Daniel (dB.) Doubrovkine

Be able to use `using`, `proc` and `format_with` together

Labeled this as a feature.

Expose collection of items of different types without keys

I have been using Roar in production as well, and cannot encourage everyone to stick to a Hypermedia standard enough. So, I would welcome Grape::Entity support for HAL and JSON...

Grape::Entity::Delegator::HashObject fails when extracting string keys

Treating hash keys indifferently is probably a good idea, but I wouldn't just change it. Start by writing some specs around this and then see whether this change has an...

Grape::Entity::Delegator::HashObject fails when extracting string keys

@nbulaj I think you should PR it and we can take a look.

Using entities as grape params cause invalid fields?

I am no expert on this, but `requires :none` looks suspicious, that is supposed to make `:name and :email` required). What do you `POST`? Care to write a small repro...

Unexpose always throw exception

Seems to be reloader-related. Can you please turn this into a spec or something that we can see that reproduces the problem?

Expose with :if and lambda stopped working on Ruby 2.4.1

I would start by adding 2.4.1 to the build matrix, first Grape, then grape-entity.

Ability to "flatten" nested entities into parent (e.g. for CSV)

This would need tests, README and CHANGELOG entries. And of course a passing build. Thanks for contributing!

Ability to "flatten" nested entities into parent (e.g. for CSV)

I want to play devil's advocate for this feature for a second. Can't this be accomplished outside of presenters? I mean flattening a JSON generically may be easier ([like this](http://stackoverflow.com/questions/10712679/flatten-a-nested-json-object)...

Ability to "flatten" nested entities into parent (e.g. for CSV)

I'd love to hear what others think of this - will leave it open for a bit. In the meantime you might want to squash the commits/rebase this PR.