David Baker

Results 218 comments of David Baker

Change `timeoutIdRef` type number to `ReturnType<typeof setTimout>`

Not a problem, its just that open PRs come up in our weekly meeting so if they're still open so we look at how to move them along.

Implement download_file in widget driver

I've merged the widgets api PR and released it as 1.9.0 so you'll need tov change the dependency here (or allow edits so we can).

Disable profile controls if the HS doesn't allow them to be set

Aaaargh, sorry for the mess on this PR, I had a complete failure pressing the merge button on a PR stacked on top of this one and it's going downhill...

Switch sliding sync support to simplified sliding sync

Force merging because the upstream will be incompatible

Sliding sync: remove the list ops from the response

Yep, I don't really know - Kegan is the expert here, but this all sounds plausible. It's not completely ideal that the server & clients might have subtle differences /...

Electron 36 fails to launch because "Using GTK 2/3 and GTK 4 in the same process is not supported"

Reverted to 35 in https://github.com/element-hq/element-desktop/pull/2298

Give room list search results by members too

Yeah, could be nice but subtle to get right, eg. it could be very confusing why a room is included in the results if it happened to contain a user...

Add proposal for mid based signalling

Yeah, seems so.

Breadcrumbs (top of roomlist) are not reordering based on most recent room view any more.

I can't repro this on my account (on nightly), they're re-ordering as I change rooms.

New icons lack transparent background

This isn't particularly helpful or constructive. If what you're saying is what the icon has a white background in some circumstances, which I'm guessing from your screenshot, you could provide...