read from buffer

[tj]

would you be interested in a patch for reading from a buffer? in our case we have the blob in memory already so less IO would be nice

[dberesford]

Hi TJ - sounds interesting, and yes, definitely interested!

[drewish]

Looks like someone did a fork to handle that usecase: https://www.npmjs.com/package/exiv2-buffers

[rayshan]

+1 would you be interested to merge fork's changes back into master? Would help when used as a gulp plugin.

cc @bertrandom

[dberesford]

@rayshan yes interested of course - pull requests very welcome!

[bertrandom]

Hi! I made the fork, I'll try to make a PR when I have a moment free.

[JDOSR]

I've add issues trying to install the exiv2-buffers package, has anyone been able to install the node dependency? The original package works fine, this package, much like the gem, breaks on accessing the exiv2/image.hpp

CXX(target) Release/obj.target/exiv2/exiv2node.o ../exiv2node.cc:9:10: fatal error: 'exiv2/image.hpp' file not found #include <exiv2/image.hpp> ^ 1 error generated. make: *** [Release/obj.target/exiv2/exiv2node.o] Error 1

Anyone have success with this?

[atwright147]

@bertrandom (or anybody else) would you be willing to get your code updated to be compatible with the current state of exiv2node?

I could really use the updated functionality but I don't know enough about how this works or C to be able to do it myself

[valpackett]

@atwright147 I've implemented buffer support, but only reading tags/previews works for now, not writing/deleting (looks like the buffer gets copied somewhere in the V8 API and the updated buffer doesn't get into JS land)

[atwright147]

@myfreeweb Awesome! I'll try this out when I get chance :)

[atwright147]

@myfreeweb Would you please see if your fork fixes this issue?: https://github.com/dberesford/exiv2node/issues/49

[valpackett]

@atwright147 yep my fork gets two correct tiff images

[atwright147]

@myfreeweb could you enable issues for that repo please? I have one to report :)

[valpackett]

@atwright147 sure