RAiDER icon indicating copy to clipboard operation
RAiDER copied to clipboard

Add catch for when calling tropo_delay as a fcn

Open jlmaurer opened this issue 1 year ago • 2 comments

Addresses #623

Description

If you call tropo_delay in Python and you don't explicitly set the grid in the AOI object first, _get_delays_on_cube errors out due to missing the xpts and ypts attributes. xpts and ypts are only intermediate variables, they don't actually matter in terms of your output grid, they always get set properly from the command line, and as long as you set the grid properly prior to called tropo_delay you have no problem. However, this easy addition allows a user to skip setting up the intermediate grid.

Motivation and Context

Addresses #623

How Has This Been Tested?

  • Added a unit test that replicates the original issue
  • All other unit tests pass

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • [ ] I have added an explanation of what your changes do and why you'd like us to include them.
  • [x] I have written new tests for your core changes, as applicable.
  • [x] I have successfully ran tests with your changes locally.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.

jlmaurer avatar Jan 17 '24 22:01 jlmaurer

This is waiting for #629 because GMAO is failing.

jlmaurer avatar Feb 13 '24 01:02 jlmaurer

This is waiting for #629 because GMAO is failing.

This is ready now!

jlmaurer avatar Feb 20 '24 22:02 jlmaurer

There is an issue with dem_stitcher that is causing some of the current test failures, documented here.

jlmaurer avatar Jun 27 '24 15:06 jlmaurer