pgcli icon indicating copy to clipboard operation
pgcli copied to clipboard

add python 3.11 support

Open meeuw opened this issue 2 years ago • 3 comments

Description

Add Python 3.11 support, as requested for Fedora in: https://bugzilla.redhat.com/show_bug.cgi?id=2098775

The tests are failing in Fedora so I guess this PR needs some extra work.

Checklist

  • [ ] I've added this contribution to the changelog.rst.
  • [x] I've added my name to the AUTHORS file (or it's already there).
  • [ ] I installed pre-commit hooks (pip install pre-commit && pre-commit install), and ran black on my code.
  • [x] Please squash merge this pull request (uncheck if you'd like us to merge as multiple commits)

meeuw avatar Jul 10 '22 10:07 meeuw

Codecov Report

Base: 84.15% // Head: 80.07% // Decreases project coverage by -4.07% :warning:

Coverage data is based on head (0748743) compared to base (6884c29). Patch coverage: 33.22% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1356      +/-   ##
==========================================
- Coverage   84.15%   80.07%   -4.08%     
==========================================
  Files          21       23       +2     
  Lines        2720     2148     -572     
==========================================
- Hits         2289     1720     -569     
+ Misses        431      428       -3     
Impacted Files Coverage Δ
pgcli/packages/parseutils/tables.py 97.67% <ø> (ø)
pgcli/packages/sqlcompletion.py 97.67% <ø> (ø)
pgcli/pgtoolbar.py 31.57% <0.00%> (+0.15%) :arrow_up:
pgcli/pyev.py 15.38% <15.38%> (ø)
pgcli/explain_output_formatter.py 46.15% <46.15%> (ø)
pgcli/key_bindings.py 52.94% <50.00%> (-0.19%) :arrow_down:
pgcli/pgexecute.py 83.22% <79.59%> (+2.86%) :arrow_up:
pgcli/auth.py 91.30% <91.30%> (ø)
pgcli/packages/prioritization.py 96.96% <0.00%> (-3.04%) :arrow_down:
pgcli/packages/parseutils/__init__.py 100.00% <0.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Jul 10 '22 10:07 codecov-commenter

I think it's ready to merge, any concerns? @meeuw

laixintao avatar Jul 22 '22 16:07 laixintao

Hi @laixintao thanks for the reminder! No concerns but it might be better to wait until py3.11 is released 😊

meeuw avatar Aug 06 '22 19:08 meeuw