pgcli
pgcli copied to clipboard
Support history_file configuration per dsn, and --history option.
Description
This feature enables the user to config history file location for specific dsn.
close: #535
TODOs
- [ ]
--hisfilesupport - [ ] history file per database
- [ ] switch history file when switch database
- [ ] alias dsn histfile
Checklist
- [ ] I've added this contribution to the
changelog.rst. - [ ] I've added my name to the
AUTHORSfile (or it's already there).
- [ ] I installed pre-commit hooks (
pip install pre-commit && pre-commit install), and ranblackon my code. - [x] Please squash merge this pull request (uncheck if you'd like us to merge as multiple commits)
Codecov Report
Merging #1216 (2588068) into master (7626d9a) will decrease coverage by
0.01%. The diff coverage is77.77%.
@@ Coverage Diff @@
## master #1216 +/- ##
==========================================
- Coverage 83.78% 83.76% -0.02%
==========================================
Files 21 21
Lines 2559 2563 +4
==========================================
+ Hits 2144 2147 +3
- Misses 415 416 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| pgcli/main.py | 75.63% <77.77%> (-0.01%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 7626d9a...2588068. Read the comment docs.
I like this feature and would love this PR to come through. @laixintao are you still working on this. Is there something I can do to help?
Yes still working on it, but I just changed my job and got married last month so this PR was delayed.
I will get back to this recently, sorry.
On Wed, Jan 13, 2021 at 1:27 PM Guru Devanla [email protected] wrote:
I like this feature and would love this PR to come through. @laixintao https://github.com/laixintao are you still working on this. Is there something I can do to help?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dbcli/pgcli/pull/1216#issuecomment-759214220, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJ2JIYLC32ZEQUNG5IDP5DSZUVKRANCNFSM4SR22KUQ .
I am so sorry, totally forgot this PR. I will get back to this