mycli icon indicating copy to clipboard operation
mycli copied to clipboard

Remove vi-mode bindings for prettify/unprettify functionality

Open rolandwalker opened this issue 3 years ago • 2 comments

Description

Fixes #1087 .

I thought this implementation was correct, but I don't use vi-mode, and we have an issue from a user who does. Best to remove the vi bindings. Perhaps someone who uses vi-mode can PR better bindings.

Checklist

  • [x] I've added this contribution to the changelog.md.
  • [x] I've added my name to the AUTHORS file (or it's already there).

rolandwalker avatar Sep 17 '22 14:09 rolandwalker

Codecov Report

Base: 67.92% // Head: 66.59% // Decreases project coverage by -1.32% :warning:

Coverage data is based on head (660cf45) compared to base (48bd4c9). Patch coverage: 32.05% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1089      +/-   ##
==========================================
- Coverage   67.92%   66.59%   -1.33%     
==========================================
  Files          26       26              
  Lines        2756     2823      +67     
==========================================
+ Hits         1872     1880       +8     
- Misses        884      943      +59     
Impacted Files Coverage Δ
mycli/clitoolbar.py 29.62% <0.00%> (-3.71%) :arrow_down:
mycli/key_bindings.py 35.13% <20.00%> (-8.87%) :arrow_down:
mycli/main.py 63.49% <27.27%> (-1.79%) :arrow_down:
mycli/packages/completion_engine.py 61.90% <50.00%> (-0.17%) :arrow_down:
mycli/sqlcompleter.py 81.89% <55.55%> (-2.39%) :arrow_down:
mycli/completion_refresher.py 90.00% <80.00%> (-0.91%) :arrow_down:
mycli/__init__.py 100.00% <100.00%> (ø)
mycli/config.py 62.23% <0.00%> (-1.07%) :arrow_down:
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Sep 17 '22 14:09 codecov-commenter

This pull request introduces 1 alert when merging 2980dcc01cf7b941e1322b781c018db522cb38d6 into bc9492a2d425c4d4908c1bfc97c316739a284b9f - view on LGTM.com

new alerts:

  • 1 for Unused import

lgtm-com[bot] avatar Sep 17 '22 15:09 lgtm-com[bot]