mycli icon indicating copy to clipboard operation
mycli copied to clipboard

Add keywords for TiDB specific functions

Open dveeden opened this issue 3 years ago • 2 comments

Description

Add the TiDB specific functions as keywords to improve auto completion.

Reference:

  • https://docs.pingcap.com/tidb/stable/tidb-functions
  • https://github.com/dbcli/mycli/pull/1071

Checklist

  • [x] I've added this contribution to the changelog.md.
  • [x] I've added my name to the AUTHORS file (or it's already there).

dveeden avatar Sep 02 '22 07:09 dveeden

@amjith these are functions as you can see in the documentation. Is this the right way to add these?

dveeden avatar Sep 02 '22 07:09 dveeden

There's a separate variable that keeps a list of functions. https://github.com/dbcli/mycli/blob/main/mycli/sqlcompleter.py#L175

If you see this specific commit (https://github.com/dbcli/mycli/pull/1071/commits/755de1ebd80d744b0542aafc139dd672ed1fef85) you'll see how I added the tidb keywords variable. You might want to do the same for the functions variable.

amjith avatar Sep 05 '22 16:09 amjith

Codecov Report

Base: 67.92% // Head: 67.99% // Increases project coverage by +0.06% :tada:

Coverage data is based on head (9a6b274) compared to base (48bd4c9). Patch coverage: 39.62% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1081      +/-   ##
==========================================
+ Coverage   67.92%   67.99%   +0.06%     
==========================================
  Files          26       24       -2     
  Lines        2756     1959     -797     
==========================================
- Hits         1872     1332     -540     
+ Misses        884      627     -257     
Impacted Files Coverage Δ
mycli/clitoolbar.py 29.62% <0.00%> (-3.71%) :arrow_down:
mycli/key_bindings.py 36.84% <25.92%> (-7.16%) :arrow_down:
mycli/packages/completion_engine.py 61.90% <50.00%> (-0.17%) :arrow_down:
mycli/sqlcompleter.py 81.77% <57.14%> (-2.50%) :arrow_down:
mycli/completion_refresher.py 88.88% <71.42%> (-2.03%) :arrow_down:
mycli/config.py 62.23% <0.00%> (-1.07%) :arrow_down:
mycli/main.py
mycli/packages/special/iocommands.py 64.09% <0.00%> (+0.10%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Sep 23 '22 07:09 codecov-commenter

@amjith is this ok?

dveeden avatar Sep 27 '22 20:09 dveeden

@amjith Did you have time to look at this?

dveeden avatar Oct 18 '22 11:10 dveeden

Sorry about the delay in reviewing this.

amjith avatar Nov 08 '22 14:11 amjith