Basket icon indicating copy to clipboard operation
Basket copied to clipboard

Add support for proxy handling

Open pasternak opened this issue 10 years ago • 1 comments

Hey,

i'm not sure if you are still maintaining this package because there is no updates since 2012. I would be happy if you can consider to review and eventually add my updates. My changes:

  • I've added support for proxy (xmlrpclib and urllib2)
  • support for older versions of python was added as well.

cheers, Karol

pasternak avatar May 22 '15 08:05 pasternak

Thanks for your contribution, Karol. Your changes looks good and useful. I added a few comments, though. ;)

That said, I don't maintain Basket anymore. Recent versions of pip (which still supports Python 2.6, and perhaps even older versions) have a download cache that makes Basket mostly useless. You can (and probably should) use pip to replace Basket, even if you do not use pip for your project:

  • create a (throwable) virtual environment;
  • run pip install <package> (just like you did basket download <package>), pip install -e ../path/to/your/python/package or pip install requirements.txt.

That will keep downloaded packages in a cache (~/.cache/pip/ by default but you can configure it). That's more or less what Basket did, actually. And pip does much more than Basket:

  • it tries harder to download packages (see "Limitations" in the documentation of Basket);
  • it correctly handles the versions of required packages (ditto);
  • it handles packages that are not "sdist" (wheels and binaries, for example);

I do not think that pip has a command that does what basket purge does, but a shell script can probably do the trick. Or maybe a scary invocation of find. :)

Anyway, if you amend your changes, I could probably merge them but I won't cut a new release of Basket. If you're interested, you could fork the repository and I would add a link to your fork, indicating that you are the new maintainer. I could also grant you the owner role of the Basket account in PyPI repository.

dbaty avatar Jun 06 '15 22:06 dbaty

I'm archiving this repository and thus closing this pull request. Basket does not work anymore and has not been supported for years (as this issue subtly suggests). I just added a note in the README about that, with a migration guide to pip: https://github.com/dbaty/Basket#readme.

dbaty avatar Jul 24 '23 14:07 dbaty