book-nlp icon indicating copy to clipboard operation
book-nlp copied to clipboard

Fix filtering of characters

Open smilli opened this issue 9 years ago • 0 comments

Right now if BookNLP finds character names such as "Sakura Kinomoto" and "Kinomoto Sakura" it flags both both "Sakura Kinomoto" and "Kinomoto Sakura" because they are subsets of each other, so the character ends up not being added at all. I made a fix to add the character name with earliest lexicographic order in that case.

I think that the getVariants method still has to be modified to include both of them though. Because "Kinomoto Sakura" is the name that will end up getting ended, but "Sakura Kinomoto" isn't found in the getVariants part.

smilli avatar May 19 '16 16:05 smilli