node-datadog-metrics
node-datadog-metrics copied to clipboard
dbader
Call for Co-maintainers
I don't really do much NodeJS at the moment and I no longer personally have code in production that's using node-datadog-metrics.
Anybody interested in coming onboard as a co-maintainer to prep a new release? Would love to see this project in good hands :)
@ErikBoesen Excellent, I'll send you a collaborator invite now :) What's your username on npm?
Perfect, I just added you as a maintainer on npm as well: https://www.npmjs.com/package/datadog-metrics
As far as permissions and access go you should be all set to push out new releases :)
I'd like to help as well!
There is an issue with one of the dependencies of this project, dogapi that I'd like to start with. That library relies on json-bigint which currently has a bug that prevents it from being used with Webpack.
This caused my team and others at my org to abandon this project over a statsd flavor. Would love to update this project to remove the dogapi dependency (which hasn't been updated in months).
I'd like to update this project to use https://github.com/DataDog/datadog-api-client-typescript
Updated the project to Node LTS 15.x and dropped support for dogapi (which uses a package breaking Webpack support), in favor of an updated flavor provided by Datadog.
Had to drop support for agents since the library didn't support them.
All other semantics are completely left intact.
@thatguychrisw Appreciate the contribution! Could you open a pull request for further discussion?
I don’t know that I necessarily have the bandwidth to help with long-term maintenance, but I do have a fair amount of extra bandwidth I could use to help with things here over the next two weeks or so. Happy to submit some more pull requests to address some of the more important issues or modernize some of the syntax (since the minimum Node.js version is now 12) or tooling (Chai is out of date and some of the linting tools used here are no longer maintained), or possibly update comments to use TypeScript-style JSDoc so type annotations can be built automatically.
Let me know what you’d like to prioritize if that’s helpful. (Also #52, which seems to really be about adding an error callback to init, seems like a big deal.)
@Mr0grog All those things you mentioned sound good. #54 also seems rather pressing. I would also vote for making you a collaborator regardless as you seem to be very skilled with modern Node design and your eyes on other PRs/issues that people might open would be great in the future, although of course no pressure to continue contributing at the same amazing pace. (I frankly also don't work in Node much these days and won't claim to be particularly up to date on best practices.)
Well, I suppose I’m happy to help out when I can. Just can’t promise much availability for it past the end of this month. :)
Also, would you mind changing the default branch name to main (or giving me the power to, if you are making me a maintainer)?
@Mr0grog Invite sent :)
re: branch rename -- I'm onboard with that, as long as someone makes sure CI and npm deploys still work. Please coordinate with @ErikBoesen before making any changes. I basically have zero time at the moment to work on this library or add/fix stuff (mainly because I no longer have an active use case for it).
I'm onboard with that, as long as someone makes sure CI and npm deploys still work.
👍 Continuing this discussion in #75 so as not to derail this thread.