mono icon indicating copy to clipboard operation
mono copied to clipboard

DBButton: empty prop `variant=""` creates unexpected combination of variants filled and outlined

Open mfranzke opened this issue 10 months ago • 4 comments

Which generators are impacted?

  • [x] All
  • [ ] HTML
  • [ ] React
  • [ ] Angular
  • [ ] Vue
  • [ ] Web components
  • [ ] Power Apps

Reproduction case

empty prop variant="" creates unexpected combination of variants filled and outlined

Expected Behaviour

tbd

Screenshots

No response

Browser version

None

Add any other context about the problem here.

No response

mfranzke avatar Apr 08 '24 05:04 mfranzke

@bruno-sch is it only in vue or can we reproduce it here?

nmerget avatar Apr 12 '24 06:04 nmerget

@nmerget yes, this bug can be reproduced in any framework or just by using html + css.

bruno-sch avatar Apr 15 '24 14:04 bruno-sch

@nmerget yes, this bug can be reproduced in any framework or just by using html + css.

If I open https://db-ui.github.io/mono/review/main/components/button/overview and change it in the dom nothing happens

nmerget avatar Apr 15 '24 15:04 nmerget

Sorry, my mistake: you have to use data-variant="" to see the bug. But anyway, I've already fixed the bug and linked the PR...

Bildschirmfoto 2024-04-15 um 17 14 07

bruno-sch avatar Apr 15 '24 15:04 bruno-sch