mono icon indicating copy to clipboard operation
mono copied to clipboard

refactor: updated `actions/github-script`

Open mfranzke opened this issue 11 months ago • 8 comments

Proposed changes

Resolves https://github.com/db-ui/mono/issues/2375

Types of changes

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [x] Refactoring (fix on existing components or architectural decisions)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation Update (if none of the other choices apply)

Further comments

mfranzke avatar Mar 21 '24 11:03 mfranzke

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/2375-chore-updated-actionsgithub-script

github-actions[bot] avatar Mar 21 '24 11:03 github-actions[bot]

@nmerget there are two new features based on the changelog – as you're much more aware of the pipeline implementation, is there something that we need to further change on this PR?

mfranzke avatar Mar 21 '24 11:03 mfranzke

@nmerget there are two new features based on the changelog – as you're much more aware of the pipeline implementation, is there something that we need to further change on this PR?

It's fine, the changes won't affect us besides node20

nmerget avatar Mar 22 '24 07:03 nmerget

@nmerget there are two new features based on the changelog – as you're much more aware of the pipeline implementation, is there something that we need to further change on this PR?

It's fine, the changes won't affect us besides node20

@nmerget okay, in other words, would we profit somehow by adapting our code to these new features, or wouldn't they be of any need for us?

mfranzke avatar Mar 22 '24 08:03 mfranzke

@nmerget there are two new features based on the changelog – as you're much more aware of the pipeline implementation, is there something that we need to further change on this PR?

It's fine, the changes won't affect us besides node20

@nmerget okay, in other words, would we profit somehow by adapting our code to these new features, or wouldn't they be of any need for us?

We don't have the need, if the pipeline runs it's okay. We can check in the future if we can improve it somehow

nmerget avatar Mar 22 '24 08:03 nmerget

@nmerget there are two new features based on the changelog – as you're much more aware of the pipeline implementation, is there something that we need to further change on this PR?

It's fine, the changes won't affect us besides node20

@nmerget okay, in other words, would we profit somehow by adapting our code to these new features, or wouldn't they be of any need for us?

We don't have the need, if the pipeline runs it's okay. We can check in the future if we can improve it somehow

why not today? what would be (another) trigger in the future ?

mfranzke avatar Mar 22 '24 08:03 mfranzke

@nmerget there are two new features based on the changelog – as you're much more aware of the pipeline implementation, is there something that we need to further change on this PR?

It's fine, the changes won't affect us besides node20

@nmerget okay, in other words, would we profit somehow by adapting our code to these new features, or wouldn't they be of any need for us?

We don't have the need, if the pipeline runs it's okay. We can check in the future if we can improve it somehow

why not today? what would be (another) trigger in the future ?

Because we want to release a beta version? If you have time for it, do it ;)

nmerget avatar Mar 22 '24 15:03 nmerget

@nmerget there are two new features based on the changelog – as you're much more aware of the pipeline implementation, is there something that we need to further change on this PR?

It's fine, the changes won't affect us besides node20

@nmerget okay, in other words, would we profit somehow by adapting our code to these new features, or wouldn't they be of any need for us?

We don't have the need, if the pipeline runs it's okay. We can check in the future if we can improve it somehow

why not today? what would be (another) trigger in the future ?

Because we want to release a beta version? If you have time for it, do it ;)

I've moved the target for this update to the next release after Beta.

mfranzke avatar Mar 22 '24 15:03 mfranzke

fixed with https://github.com/db-ui/mono/pull/2837

mfranzke avatar Jul 08 '24 12:07 mfranzke