19/06/03 dotnet port

[daz10000]

[chrismacklin]

Wow, this is a beast.

[daz10000]

Yeah, I'm still doing a tiny bit of work to get the nuget packaging working so this isn't quite ready. I did get mysql mostly working except for 3 tests so I'll leave it for now but was sorly tempted to put it out of its misery - even setting up a test db is a PITA

On Mon, Jun 10, 2019 at 11:32:27AM -0700, Chris Macklin wrote:

chrismacklin commented on this pull request.

•    Assert.IsTrue(conn.ExecuteScalar "SELECT COUNT(*) FROM test1" :?> int64 = 0L)
  

•    let results : test1 [] = trans.Query "select * from test1"  |> Array.ofSeq
  

•    Assert.IsTrue(results.Length=3)
  

•    Assert.IsTrue(trans.ExecuteScalar "SELECT COUNT(*) FROM test1" :?> int64 = 3L)
  

•    trans2.Commit()
  

•    // the conn only sees 1 result, because only trans2 has been committed
  

•    let results2: test1 [] = conn.Query "select * from test1"  |> Array.ofSeq
  

•    Assert.IsTrue(results2.Length=1)
  

•    Assert.IsTrue(conn.ExecuteScalar "SELECT COUNT(*) FROM test1" :?> int64 = 1L)
  

•    // trans see's 4, because READCOMMIT allows us to see the commit
  

•    // from trans2 as well as our own.
  

• // broken

Perhaps it is time to just entirely drop support for mysql? Amyris isn't using it anymore; no idea if there are other clients of this framework.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/daz10000/fss/pull/6#pullrequestreview-247772363

[daz10000]

This should be good for review now if you're interested. I need one of the dotnet core friendly libraries, so would like to push that next 24 hours or so. Ok if you don't have time to review.

[daz10000]

BTW, I have struggled to get build.sh working. Follow readme to just install fake as a dotnet cli tool and just do fake run long story

[daz10000]

Should just build with ./build.sh in root but would be nice to get an independent test of that,

[chrismacklin]

Built successfully on my linux box up to tests, but I don't have the requisite databases set up to run the unit tests.