daytona icon indicating copy to clipboard operation
daytona copied to clipboard

TUI flashes on and off during daytona create

Open idagelic opened this issue 11 months ago • 16 comments

Describe the bug When selecting a Git provider; a namespace; a repository; a branch, the TUI disappears between each selection screen and the terminal flashes back into view

To Reproduce Steps to reproduce the behavior:

  1. Register 2 git providers with daytona git-provider add
  2. Run daytona create
  3. Select a git provider, a namespace, a repository, a branch
  4. You will notice the TUI "flashing"/opening and closing inbetween steps

Expected behavior We should improve the user experience by figuring out a way to avoid the terminal flashing

Demo

https://github.com/daytonaio/daytona/assets/25279767/065c67de-c0fe-4314-aeeb-27ef68d0977f

Desktop (please complete the following information): Applicable to any OS / terminal

idagelic avatar Mar 08 '24 12:03 idagelic

💎 $30 bounty created by daytonaio 🙋 If you start working on this, comment /attempt #131 along with your implementation plan 👉 To claim this bounty, submit a pull request that includes the text /claim #131 somewhere in its body 📝 Before proceeding, please make sure you can receive payouts in your country 💵 Payment arrives in your account 2-5 days after the bounty is rewarded 💯 You keep 100% of the bounty award 🙏 Thank you for contributing to daytonaio/daytona!

👉 Add a bountyShare on socials

If no one is assigned to the issue, feel free to tackle it, without confirmation from us, after registering your attempt. In the event that multiple PRs are made from different people, we will generally accept those with the cleanest code.

Attempt Started (GMT+0) Solution
🟢 @Vijaykv5 Mar 9, 2024, 4:41:38 AM WIP
🔴 @ezhil56x Mar 11, 2024, 3:55:14 PM WIP
🔴 @vineeth-vk11 Mar 12, 2024, 3:25:46 AM WIP
🟢 @harkiratsm #361

algora-pbc[bot] avatar Mar 08 '24 14:03 algora-pbc[bot]

I would like to give a try @idagelic May you can assign me the issue?

Vijaykv5 avatar Mar 08 '24 19:03 Vijaykv5

Hey @Vijaykv5 thank you for the request. Yes, I will assign this to you right away - good luck coding!

idagelic avatar Mar 08 '24 19:03 idagelic

/attempt #131

Vijaykv5 avatar Mar 09 '24 04:03 Vijaykv5

@idagelic I'm having some issue to fix it. May you can suggest me a good approach for resolution of the above issue?

Vijaykv5 avatar Mar 11 '24 14:03 Vijaykv5

Cancelled my attempt

ezhil56x avatar Mar 11 '24 15:03 ezhil56x

@ezhil56x I've cleared the assignees from this issue. You are free to try and solve it. Please just start an Algora attempt beforehand from the comments here.

Tpuljak avatar Mar 11 '24 15:03 Tpuljak

/attempt #131

Algora profile Completed bounties Tech Active attempts Options
@vineeth-vk11 1 daytonaio bounty
Java, JavaScript
Cancel attempt

vineeth-vk11 avatar Mar 12 '24 03:03 vineeth-vk11

We can incorporate a loader to enhance the UX during the selection process. // @Tpuljak

harkiratsm avatar Mar 13 '24 07:03 harkiratsm

@harkiratsm leaving the TUI stuff to @idagelic. He's the expert on that matter

Tpuljak avatar Mar 13 '24 08:03 Tpuljak

Consider a progress bar or log messages like 'Fetching gitproviders...' to indicate activity during the workflow create command. Thoughts? @idagelic

https://github.com/daytonaio/daytona/assets/71957674/0bb7707a-9e22-4a10-bf80-7ee7da9843e6

harkiratsm avatar Mar 15 '24 10:03 harkiratsm

can i assigned to this issue i will try to fix it @idagelic

DushyantDewangan7 avatar Mar 15 '24 11:03 DushyantDewangan7

No need to get assigned, feel free to work on it and submit a PR.

@harkiratsm That's good, but the UI still flashes between choices. If possible, this should all happen in the same view.

Tpuljak avatar Mar 15 '24 11:03 Tpuljak

All within the same alternate screen

https://github.com/daytonaio/daytona/assets/71957674/13d2e5ef-c3a6-4468-b280-6beab4fc32e2

harkiratsm avatar Mar 15 '24 17:03 harkiratsm

@harkiratsm that's great!

Tpuljak avatar Mar 15 '24 17:03 Tpuljak

@harkiratsm are you interested in working on this?

Tpuljak avatar Mar 25 '24 08:03 Tpuljak

💡 @harkiratsm submitted a pull request that claims the bounty. You can visit your bounty board to reward.

algora-pbc[bot] avatar Apr 08 '24 07:04 algora-pbc[bot]

🎉🎈 @harkiratsm has been awarded $30! 🎈🎊

algora-pbc[bot] avatar Apr 09 '24 11:04 algora-pbc[bot]