daytona
daytona copied to clipboard
daytonaio
Improve info command
Improve info command
Description
- This PR is to improve
daytona infocommand in cli - Added support to display WorkspaceId, Target, RepositoryUrl
Fixes #114 /claim #114
Type of Change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
Checklist
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
Related Issue(s)
This PR addresses issue #114
Screenshots
Thank you for the PR @ezhil56x
This looks good - just a couple of changes: As you can see in the screenshot of a multi project workspace below, we should move the “repository url” to the projects section between each project name and state line. While you/re at it, also rename the wokrspaceURLStyle to repositoryURLStyle since the repository is the one that has the URL.
Last thing we could do is change the label WorkspaceId to just “ID” for less clutter.
Additionally, if you didn't already, please read through our contributing guidelines. Specifically, this section which requires you to add your username to the CONTRIBUTORS.md file.
@ezhil56x By the way, here is an example of adding your entry to CONTRIBUTORS.md - a separate PR and specific commit message: https://github.com/daytonaio/daytona/commit/2f3e8b9ac3ce1bdf3f379ab3ad9f2951cd02fb41
@idagelic Added to CONTRIBUTORS.md and made required changes. Can you review once?
Screenshot after changes
Thanks @ezhil56x - last thing I would ask you to do is to remove the contribution commit from this PR and add it to another one just like this https://github.com/daytonaio/daytona/commit/2f3e8b9ac3ce1bdf3f379ab3ad9f2951cd02fb41 - with a commit message chore: add "username" to contributors and submit it as well.