Dayoung Lee

Results 82 comments of Dayoung Lee

@hyunsik-yoon As you can see below, it's MS vscode's recommendation to use their api for filesystem approaches. vscode/index.d.ts>vscode.workspace.fs ```js /** * A {@link FileSystem file system} instance that allows to...

@YongseopKim Yes, if you use `fs.promises.writeFile`, then it's rather similar to `vscode.workspace.fs.writeFile`. The differences are 1. `fs.promises.writeFile` returns promise while `vscode.workspace.fs.writeFile` returns Thenable. 2. `fs.promises.writeFile` takes string while `vscode.workspace.fs.writeFile` takes...

@YongseopKim Nope, it's a basic fs module. They just support `promises` version of their functions.

### NOTE: `vscode.workspace.fs` doesn't support synchronous functions. https://github.com/microsoft/vscode/issues/84175#issuecomment-551445383 > readFileSync() - currently using node's fs.readFileSync() Our design/architecture prohibits anything sync here. This will not happen. It seems that they internally...

### NOTE: vscode.workspace.fs is too slow I tested the function latency. As `vscode.workspace.fs` is asynchronouse function, I wrapped the statSync with promise. - vscode.workspace.fs: 1721 ms - Promise + fs.statSync:...

@stamalakhov It was planned and drafted last year, but not merged. If you are interested, you can go on with that. I am currently not planned, too

\+ @jinevening **For other reviewers**, to summarize: I suggested adding 'default configuration' or 'per-layer configuration' title to each area as below. > > Hi, this is another UI feedback. >...

I just got another idea - how about adding 'default' just as the same as the other layers? Not as a radio button, but just as a drop box element...

triggering command / automatic refresh | directory | base model | cfg | products -- | -- | -- | -- | -- create | - | refactor / O...