selecto icon indicating copy to clipboard operation
selecto copied to clipboard

Mouse down and drag on target not working with react-moveable.

Open joel1st opened this issue 3 years ago • 3 comments

After upgrading react-selecto from v1.7.4 to v1.9.2 the mouse down and drag no longer works when moving an element with react-moveable, unless you explicitly click (mouse down & up) and then drag. This behaviour can be reproduced in the example: https://daybrush.com/selecto/storybook/?path=/story/selecto-with-moveable--select-moveable-targets-in-real-time

Expected behaviour: mousedownanddragworking

Observed behaviour (mouse is held down, but the element does not move): mousedownanddragnotworking

As a side note, it would be good to couple the exact version of selecto to a given framework release (eg 1.7.4 of react-selecto should install "1.7.4" of selecto not "^1.7.4") - The cause of this issue was hard to track down because after removing my package-lock.json and reinstalling 1.7.4 of react-selecto the issue was still occuring - only after looking into the package-lock.json was it apparent that 1.7.4 had installed 1.9.2 of selecto because of the '^'

joel1st avatar Nov 11 '20 01:11 joel1st

@joel1st

  • selecto 1.10.1
  • react-selecto 1.10.1
  • preact-selecto 1.9.1
  • ngx-selecto 1.10.1
  • svelte-selecto 1.10.1
  • lit-selecto 1.10.1

selecto's new version is released. Try it again.

daybrush avatar Nov 14 '20 18:11 daybrush

Hey @daybrush - yes I will give this a go tomorrow and let you know if it works. Is there any chance you can consider the second part of this issue (remove the selecto ^ from the framework package.json)? I'm slightly nervous to use this package if the selecto + react-selecto versions are not coupled together (as builds are not reproducible in the future, if package-lock needs to be deleted or i need to install a version that is not the latest).

joel1st avatar Nov 15 '20 00:11 joel1st

@joel1st

That's a good idea. ~ Or try to bind to that version.

daybrush avatar Nov 15 '20 06:11 daybrush