Dax Fohl

Also note that while investigating the issue, I noticed that the existing behavior of INLINE is probably not what we really wanted, or what users would intuitively expect. In particular,...

short and sweet. cc @mhucka since you were on the linked issue thread.

Actually it seems to be the varargs format. In https://quantumai.google/reference/python/cirq/circuits/CircuitOperations there are plenty of forward references that work, but with_qubits is broken even though annotated correctly.

Quick note on this: a few of the classes that implement `_decompose_with_context_` also define a `def _decompose_(...): self._decompose_with_context_(context=None)`, which does pass `None` in for `context`. So it would seem that...

One exception to the above comment: removing `GateOperation._decompose_` is problematic because `SingleQubitPauliStringGateOperation` inherits both `GateOperation` and `PauliString`. Currently the `GateOperation._decompose_` hides `PauliString._decompose_`, but if we delete the former, then the...

Historical context: `single_qubit_state_tomography` was written years before `Result.record` field was created to support subcircuits with loops (or more specifically, circuits with multiple measurements to the same key). I'm not familiar...

@kygnz yeah if you want to give it a look. I don't have my home laptop in front of me so I'm not able to run the code. But https://github.com/quantumlib/Cirq/blob/8788b625da0a57459589d2377a27bdd0250035c3/cirq-core/cirq/circuits/circuit_operation.py#L444...

> I think we should have the tomo code pick a unique measurement key name @maffoo that's what it does already. `z` is added to the end of the circuit...

I think your original proposal is actually the best option. Changing the tomography function to use `result.records['z'][:, -1, :]` is a simple change and works even if a different `z`...

Fixed by #7477