🧪 Test helper functions

Open jtfirek opened this issue 2 years ago • 1 comments

The way we are using the helper functions in the new mocked test will not catch bugs introduced in helper functions like prepareTransaction. https://github.com/dawsbot/essential-eth/blob/69cec045b27ad20af86eb985ad68e90d90594288/src/providers/test/json-rpc-provider/call.test.ts#L81-L86 We need to make a test for testing the helpers like: prepareTransaction buildRPCPostBody toChecksumAddress cleanLog Lmk what other helpers need to be tested @dawsbot

May 08 '23 16:05 jtfirek

Great idea, feel free to make a PR for this whenever @jtfirek . It will be good to be confident our helpers are doing what we think so that one break to helper shows up in the tests right there instead of downstream and we only notice it in a different function!

May 12 '23 05:05 dawsbot