action-download-artifact icon indicating copy to clipboard operation
action-download-artifact copied to clipboard

Published 20 hours ago • verified publisher icon dawidd6

Boolean inputs aren't handled as booleans

Open amezin opened this issue 2 years ago • 2 comments

Currently, if you pass false to any of the "boolean" inputs, it will be treated as true. Because getInput() returns a string, and Boolean("false") evaluates to true.

Newer actions toolkit has core.getBooleanInput(). For it, https://github.com/dawidd6/action-download-artifact/pull/166 needs to be merged (with corresponding updates to the bundled node_modules).

amezin avatar Jul 26 '22 00:07 amezin

Could you submit a PR for that? I agree current behavior isn't what we want.

dawidd6 avatar Aug 30 '22 10:08 dawidd6

I'm not using this action anymore (got rid of cross-workflow artifact passing). And, unfortunately, I don't have the time to fix things I'm not using. From the description, it should be obvious what to fix and how.

amezin avatar Aug 30 '22 10:08 amezin