dawei-wang

Results 10 comments of dawei-wang

I think this issue can be closed as there is a merged PR that implements the changes. Thanks!

> @dawei-wang Do you have any response to [#21667 (review)](https://github.com/mdn/content/pull/21667#pullrequestreview-1148518383)? Should we go ahead and close this? @sideshowbarker yes let's go ahead and close this

@hamishwillee I'm not familiar with caching mechanisms enough to document a new one. Let's keep a red link to the old doc.

I propose changing the first bullet to read: "The down-event should not be used to trigger any action unless there is no alternative. For example when using an on-screen keyboard...

Another problem with the accessibility fix is that the screen reader will continue to announce that the page is in dark mode or light mode for five or six times...

By moving away, I mean focusing the screen reader on another part of the screen. By region, I meant the light/dark mode button.

Here's a video. I hope this makes it clearer: https://user-images.githubusercontent.com/11358567/209221266-121c645a-6930-4988-a895-5033e438e52f.mp4

@Josh-Cena That makes sense, but the menus do not expand with `enter` either. When I am on the doc version selection drop down and press enter, it takes me to...

The drop down works without the screen reader enabled but does not work if NVDA screen reader is enabled. I am on Windows 11, Edge 108

I run into the same issue if I try to access the menus with the Windows narrator turned on.