drush_language
drush_language copied to clipboard
dawehner
Convert to Drush 9 commands
@andypost interesting comments, but IMHO off-topic: this is just about converting from the Drush 8 format to the Drush 9 format, so that it can be merged sooner. Actually fixing the commands is another topic. Very much needed too, but separate.
+1 for not trying to change the world! @andypost Would you be okay with merging it otherwise?
Sure, there's more work ahead! PS: http://nuvole.org/blog/2017/oct/13/how-maintain-drush-commands-drush-8-and-9-and-drupal-console-same-code-base
I think we should merge this, at least there is something which works for someone.
Huch, why should we create a new branch, when there is nothing broken? Minor changes are used for new features.
Andy Postnikov [email protected] schrieb am Mi., 29. Nov. 2017 um 20:29 Uhr:
Yes, lets start 2.x brach with drush 9
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/dawehner/drush_language/pull/18#issuecomment-347986423, or mute the thread https://github.com/notifications/unsubscribe-auth/AABz7ukGxxsUD4bj2my88Nbv3L7PhQ9Pks5s7b6qgaJpZM4P0M9_ .
Hmm, confusing that we moved from the d.o issue to here.
I agree, a new branch is not necessary and only doubles our maintenance workload.
Please see my comment here.
Hello,
I have worked on this today. Please see my comments starting from https://www.drupal.org/project/drush_language/issues/2914081#comment-12486797 to https://www.drupal.org/project/drush_language/issues/2914081#comment-12487040
@andypost: enable and disable commands have been removed because languages in Drupal 8 don't have this attribute anymore.
Also the default language command neither worked or had been used.