dawe

Results 35 comments of dawe

Instead of disabling the QuickFix for UoM constants, we could also check if they are valid in the sig file. I tried that in the last commit. There's still work...

Because of https://github.com/dotnet/fsharp/issues/15843 we can't update the return type for UoM Literals but otherwise I think the UoM support in this CodeFix is okay now.

And here's the division by 3. ![image](https://github.com/JetBrains/resharper-fsharp/assets/3221269/95dda0e7-a76b-428b-a336-ad1a41ee3e64)

Hey, we are fine with the additional reporting of non-matching globs. But we shoudln't force the users of `FSharp.Analyzers.SDK.Client` (Editors like Ionide/FSAC) to take a dependency on `Glob`. So if...

While I like the change, I don't really want to take the risk for the release of the current week. So let's investigate what's going wrong here without rush.

@bigjonroberts Could you please check if this is still the case for you with the latest README, please.

Thanks for the reviews @psfinaki and @KevinRansom, once #17206 is merged, I'll rework this PR to use `#help` as Kevin suggested.

@KevinRansom Cool, so this is the state now: ![Screenshot from 2024-06-06 12-02-30](https://github.com/dotnet/fsharp/assets/3221269/7de24c79-f63d-4d3d-8780-38585270b163)

> @dawedawe Maybe this would ring a bell for you I'll try to find some time in a couple of days to look into it.